Skip to content

Rename the external-dependencies.js bundle to.... #5714

Closed

Description

@pkozlowski-opensource

Sooo, we all love naming discussion, here is the one! Currently we've got the external-dependencies.js bundle that contains:

  • zone.js
  • reflect-metadata

The idea was to rename it to sth like angular-polyfills.js but this name might be confusing as:

  • zone.js is not a polyffil
  • we don't include es6-shim here, which I would kind of expect from something that is named angular-polyfills.js

I guess there are 2 questions here:

  • what should be the content of this bundle (that is, shell we add es6-shim?)
  • what would be the best name for this thingy?

Activity

  1. IgorMinar commented on Dec 8, 2015

    @IgorMinar
    Contributor

    let's call it angular-polyfills.js even though it contains zone. The hope is that zone will become a polyfill in the future. So while technically some things are polyfills and others are prolyfills, we need to put them into a single bundle and this bundle should be called with something that properly represents the content. angular-polyfills.js is the closest thing to that as far as I'm concerned.

  2. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  3. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions