Skip to content

Checksums of deps with newlines trip the dep downloader #51

Closed

Description

@JackOfNoneTrades
jar:file:/home/jack/.local/share/FjordLauncher/instances/FentTest/.minecraft/mods/wawelauth-testerino-nodep.jar!/META-INF/wawelauth_fplib_dependencies.json
[17:26:20] [RFB-Main/INFO] [FalsePatternLib DepLoader]: -----------------------------------------------------------
[17:26:20] [RFB-Main/INFO] [FalsePatternLib DepLoader]: FalsePatternLib is downloading dependencies. Please wait...
[17:26:20] [RFB-Main/INFO] [FalsePatternLib DepLoader]: -----------------------------------------------------------
[17:26:20] [Dependency Download Thread/INFO] [FalsePatternLib DepLoader]: Adding library org.bouncycastle:bcpkix-jdk15to18:1.84, requested by mod jar:file:/home/jack/.local/share/FjordLauncher/instances/FentTest/.minecraft/mods/wawelauth-testerino-nodep.jar!/META-INF/wawelauth_fplib_dependencies.json
[17:26:20] [Dependency Download Thread/ERROR] [FalsePatternLib DepLoader]: Failed sha512 checksum validation for org.bouncycastle:bcpkix-jdk15to18:1.84.
[17:26:20] [Dependency Download Thread/ERROR] [FalsePatternLib DepLoader]: Failed sha512 checksum validation for org.bouncycastle:bcpkix-jdk15to18:1.84.
[17:26:20] [Dependency Download Thread/ERROR] [FalsePatternLib DepLoader]: Failed sha512 checksum validation for org.bouncycastle:bcpkix-jdk15to18:1.84.
[17:26:20] [Dependency Download Thread/FATAL] [FalsePatternLib DepLoader]: Failed to download library org.bouncycastle:bcpkix-jdk15to18:1.84 from any repository! Requested by mod: jar:file:/home/jack/.local/share/FjordLauncher/instances/FentTest/.minecraft/mods/wawelauth-testerino-nodep.jar!/META-INF/wawelauth_fplib_dependencies.json

Bouncy Castle 1.84 checksum has a newline character in its checksum file, and produces the crash. 1.80 checksum does not, and works fine:

cat -e bcprov-jdk15to18-1.84.jar.sha512
433b7f5f324cb8ff60f14cb4a69afcfc17488606d082a452a17f97276bb306db651fc67d051014d6a759eb710ebdc564e37be8227c3669869653dc34bad803e4$
cat -e bcprov-jdk15to18-1.80.jar.sha512
0960d33d41aa94c8e0460224414953a20e40196b84f4d76bd7750516718ecc2c1cddef2c0eda6846eb4b7291eb94cdda18cc5abe7cf90bcc342b0eba0054cfdb

Newlines don't seem to be stripped anywhere:

val referenceHash = new String(Files.readAllBytes(checksumFile));

Activity

  1. JackOfNoneTrades commented on May 29, 2026

    @JackOfNoneTrades
    Author

    Perfect, works as of 1.12.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions