feature/VMO-7721/SupportPhp81#20
Merged
Merged
Conversation
…g the Viamo platform to PHP 8.1, I had identified this project does not actually support PHP 8.1, even though composer says it does. I also added types, where supported by PHP 8.1, and especially where inheritance was involved, so that issues were immediately apparent. We should release this as a major revision, so that we can drop php <8 support and laravel <8 support.
…e codestyle is different in this project, and didn't notice I had the "Reformat Code" option enabled for by commit.
…ure/VMO-7721/SupportPhp81 # Conflicts: # src/php/Evaluator/LogicNodeEvaluator.php
GrimFunction
approved these changes
Feb 28, 2023
…e codestyle is different in this project, and didn't notice I had the "Reformat Code" option enabled for by commit. I added support for Rector, and ran it against the project, to speed up the migration to PHP 8.1. I also found additional cases I had to handle, and made changes as necessary. Added Types wherever possible. Found an issue with Text->substitute, consulted Kyle, and then implemented the expected behaviour, as the issue became apparent when making these changes. feature/VMO-7721/SupportPhp81 - fixed whitespace changes. I forgot the codestyle is different in this project, and didn't notice I had the "Reformat Code" option enabled for by commit. I added support for Rector, and ran it against the project, to speed up the migration to PHP 8.1. I also found additional cases I had to handle, and made changes as necessary. Added Types wherever possible. Found an issue with Text->substitute, consulted Kyle, and then implemented the expected behaviour, as the issue became apparent when making these changes.
seifertk
approved these changes
Mar 1, 2023
| return $ex; | ||
| } | ||
| private function peg_f1($id, $ex) { return call_user_func($this->_location); } | ||
| private function peg_f0($id, $ex) { |
Collaborator
There was a problem hiding this comment.
FYI this is a generated file so I wouldn't expect these changes to persist.
Collaborator
|
approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PHP 8.1 support, as in upgrading the Viamo platform to PHP 8.1
I had identified this project does not actually support PHP 8.1, even though composer says it does, so I made it compatible with PHP 8.1.
I also added types, where supported by PHP 8.1 and where I was able to add them in bulk by IDE, especially where inheritance/abstraction/interfaces were involved, so that issues were immediately apparent.
We should release this as a major revision, so that we can drop php <8 support and laravel <8 support.