GenericController cleanup - #1016
Draft
dennisvang wants to merge 16 commits into
Draft
dennisvang wants to merge 16 commits into
dennisvang wants to merge 16 commits into
Conversation
dennisvang
force-pushed
the
dev/generic-controller-cleanup
branch
from
September 25, 2026 10:46
9e3acb5 to
7a9d570
Compare
and add more explanatory comments
because in an upcoming change we want to allow non-paged children as well
so we can reuse the logic
dennisvang
force-pushed
the
dev/generic-controller-cleanup
branch
from
September 25, 2026 15:27
7763945 to
87c11d2
Compare
dennisvang
added this pull request to stack #1019
September 25, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenericControllerto constructor injection with the help of lombok@RequiredArgsConstructorgetMetaDataChildrentodo:
follow-up: port #844 to the
masterbranch