Skip to content

fix: use plain boolean for ECS control-flow flags #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
droguljic merged 1 commit into from
Jun 2, 2026
Merged

fix: use plain boolean for ECS control-flow flags #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions src/components/ecs-service/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,27 +146,27 @@ class EcsService extends pulumi.ComponentResource {

Direct constructor input: `args: EcsService.Args`

| Property | Description |
| -------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------- |
| `cluster`\*<br/>`pulumi.Input<aws.ecs.Cluster>` | ECS cluster that will run the service. |
| `vpc`\*<br/>`pulumi.Input<awsx.ec2.Vpc>` | Provides subnets, VPC ID, and CIDR-based security group rules. |
| `containers`\*<br/>`EcsService.Container[]` | Full task container list. |
| `loadBalancers`<br/>`pulumi.Input<EcsService.LoadBalancerConfig[]>` | Optional ECS service-to-target-group registrations. |
| `volumes`<br/>`pulumi.Input<pulumi.Input<EcsService.PersistentStorageVolume>[]>` | Any non-empty value triggers creation of shared EFS-backed persistent storage. Default: `[]`. |
| `name`<br/>`pulumi.Input<string>` | ECS service name override. Default: component name. |
| `deploymentController`<br/>`'ECS' \| 'CODE_DEPLOY' \| 'EXTERNAL'` | ECS deployment controller type. Default: `'ECS'`. |
| `desiredCount`<br/>`pulumi.Input<number>` | Initial desired task count. Default: `1`. |
| `family`<br/>`pulumi.Input<string>` | Task definition family. Default: `<name>-task-definition-<stack>`. |
| `size`<br/>`pulumi.Input<TaskSize>` | CPU/memory preset or explicit `{ cpu, memory }` object. Default: `'small'`. |
| `logGroupNamePrefix`<br/>`pulumi.Input<string>` | Passed to `aws.cloudwatch.LogGroup.namePrefix`. Default: `/ecs/<name>-`. |
| `securityGroup`<br/>`pulumi.Input<aws.ec2.SecurityGroup>` | If omitted, the component creates a VPC-wide internal service security group. Default: generated default SG. |
| `assignPublicIp`<br/>`pulumi.Input<boolean>` | Selects public subnets when `true`, otherwise private subnets. Default: `false`. |
| `taskExecutionRoleInlinePolicies`<br/>`pulumi.Input<pulumi.Input<EcsService.RoleInlinePolicy>[]>` | Extra inline policies merged into the generated execution role. Default: `[]`. |
| `taskRoleInlinePolicies`<br/>`pulumi.Input<pulumi.Input<EcsService.RoleInlinePolicy>[]>` | Extra inline policies merged into the generated task role. Default: `[]`. |
| `enableServiceAutoDiscovery`<br/>`pulumi.Input<boolean>` | Creates a private DNS namespace and Cloud Map service. Default: `false`. |
| `autoscaling`<br/>`pulumi.Input<{ enabled: pulumi.Input<boolean>; minCount?: pulumi.Input<number>; maxCount?: pulumi.Input<number> }>` | ECS target-tracking autoscaling configuration. Default: disabled. |
| `region`<br/>`pulumi.Input<string>` | AWS region used for region-specific ECS settings such as CloudWatch Logs. Default: active AWS provider's region. |
| `tags`<br/>`pulumi.Input<EcsService.Tags>` | Additional tags merged with the package common tags. |
| Property | Description |
| ------------------------------------------------------------------------------------------------------------------------ | ---------------------------------------------------------------------------------------------------------------- |
| `cluster`\*<br/>`pulumi.Input<aws.ecs.Cluster>` | ECS cluster that will run the service. |
| `vpc`\*<br/>`pulumi.Input<awsx.ec2.Vpc>` | Provides subnets, VPC ID, and CIDR-based security group rules. |
| `containers`\*<br/>`EcsService.Container[]` | Full task container list. |
| `loadBalancers`<br/>`pulumi.Input<EcsService.LoadBalancerConfig[]>` | Optional ECS service-to-target-group registrations. |
| `volumes`<br/>`pulumi.Input<pulumi.Input<EcsService.PersistentStorageVolume>[]>` | Any non-empty value triggers creation of shared EFS-backed persistent storage. Default: `[]`. |
| `name`<br/>`pulumi.Input<string>` | ECS service name override. Default: component name. |
| `deploymentController`<br/>`'ECS' \| 'CODE_DEPLOY' \| 'EXTERNAL'` | ECS deployment controller type. Default: `'ECS'`. |
| `desiredCount`<br/>`pulumi.Input<number>` | Initial desired task count. Default: `1`. |
| `family`<br/>`pulumi.Input<string>` | Task definition family. Default: `<name>-task-definition-<stack>`. |
| `size`<br/>`pulumi.Input<TaskSize>` | CPU/memory preset or explicit `{ cpu, memory }` object. Default: `'small'`. |
| `logGroupNamePrefix`<br/>`pulumi.Input<string>` | Passed to `aws.cloudwatch.LogGroup.namePrefix`. Default: `/ecs/<name>-`. |
| `securityGroup`<br/>`pulumi.Input<aws.ec2.SecurityGroup>` | If omitted, the component creates a VPC-wide internal service security group. Default: generated default SG. |
| `assignPublicIp`<br/>`boolean` | Selects public subnets when `true`, otherwise private subnets. Default: `false`. |
| `taskExecutionRoleInlinePolicies`<br/>`pulumi.Input<pulumi.Input<EcsService.RoleInlinePolicy>[]>` | Extra inline policies merged into the generated execution role. Default: `[]`. |
| `taskRoleInlinePolicies`<br/>`pulumi.Input<pulumi.Input<EcsService.RoleInlinePolicy>[]>` | Extra inline policies merged into the generated task role. Default: `[]`. |
| `enableServiceAutoDiscovery`<br/>`boolean` | Creates a private DNS namespace and Cloud Map service. Default: `false`. |
| `autoscaling`<br/>`pulumi.Input<{ enabled: boolean; minCount?: pulumi.Input<number>; maxCount?: pulumi.Input<number> }>` | ECS target-tracking autoscaling configuration. Default: disabled. |
| `region`<br/>`pulumi.Input<string>` | AWS region used for region-specific ECS settings such as CloudWatch Logs. Default: active AWS provider's region. |
| `tags`<br/>`pulumi.Input<EcsService.Tags>` | Additional tags merged with the package common tags. |

**Outputs**

Expand Down
6 changes: 3 additions & 3 deletions src/components/ecs-service/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export namespace EcsService {
* In case no security group is provided, default security group will be automatically created.
*/
securityGroup?: pulumi.Input<aws.ec2.SecurityGroup>;
assignPublicIp?: pulumi.Input<boolean>;
assignPublicIp?: boolean;
taskExecutionRoleInlinePolicies?: pulumi.Input<
pulumi.Input<RoleInlinePolicy>[]
>;
Expand All @@ -134,14 +134,14 @@ export namespace EcsService {
*
* @default false
*/
enableServiceAutoDiscovery?: pulumi.Input<boolean>;
enableServiceAutoDiscovery?: boolean;
autoscaling?: pulumi.Input<{
/**
* Is autoscaling enabled or disabled.
*
* @default false
*/
enabled: pulumi.Input<boolean>;
enabled: boolean;
/**
* Min capacity of the scalable target.
*
Expand Down