test: unify exponential backoff use - #187
Merged
Merged
Conversation
mandryllo
reviewed
Mar 26, 2026
Comment on lines
+66
to
+75
| await backOff(async () => { | ||
| try { | ||
| const replicaDBInstanceId = db.replica!.instance | ||
| .identifier as unknown as string; | ||
| const deleteCommand = new DeleteDBInstanceCommand({ | ||
| DBInstanceIdentifier: replicaDBInstanceId, | ||
| SkipFinalSnapshot: true, | ||
| }); | ||
|
|
||
| await ctx.clients.rds.send(deleteCommand); |
Collaborator
There was a problem hiding this comment.
Wouldn't this try to delete replica every time?
mandryllo
reviewed
Mar 26, 2026
| return; | ||
| } | ||
| }, | ||
| { numOfAttempts: 10 }, |
Collaborator
There was a problem hiding this comment.
I see an issue with removing this configuration here, in my experience it takes ~10 minutes (or even more) to delete a replica so in fact if max wait time is now ~5 minutes we should configure this backoff with that in mind (I'm ok with removing jitter)
Contributor
Author
There was a problem hiding this comment.
Bumped the max wait time to ~10 minutes. A few times I did tests in CI env ~5 minutes was sufficient to delete the replica.
mandryllo
requested changes
Mar 26, 2026
- All tests now use `util/backOff` - Max wait time is now ~10 minutes - Jitter is dropped to eliminate flaky tests - By default `NonRetryableError` stops execution
droguljic
force-pushed
the
test/unify-backoff-use
branch
from
March 27, 2026 09:53
dceba10 to
9b3f449
Compare
mandryllo
approved these changes
Mar 27, 2026
bornast
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util/backOffNonRetryableErrorstops execution