fix: ensure subnet strategy change do not affect specs ordering - #172
Merged
Conversation
Change from `Legacy` to `Auto` subnet strategy affected subnet specs ordering. `Auto` uses the provided ordering while `Legacy` enforced `Private`, `Public`, `Isolated` ordering. Ordering is updated to reflect one from `Legacy` strategy and thus avoid breaking changes.
mandryllo
approved these changes
Feb 27, 2026
bornast
approved these changes
Mar 2, 2026
MiroDojkic
reviewed
Mar 2, 2026
| enableDnsSupport: true, | ||
| subnetStrategy: enums.ec2.SubnetAllocationStrategy.Auto, | ||
| // Switching from `Legacy` to `Auto` strategy changed ordering of the specs | ||
| // `Auto` is using the provided ordering, while `Legacy` enforced `Private`, `Public`, `Isolated` ordering |
Member
There was a problem hiding this comment.
What do you mean by "Auto is using the provided ordering"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change from
LegacytoAutosubnet strategy affected subnet specs ordering.Autouses the provided ordering whileLegacyenforcedPrivate,Public,Isolatedordering.Ordering is updated to reflect one from
Legacystrategy and thus avoid breaking changes.