feat: FeastClient factory methods for pre-configured stubs#343
Merged
vanitabhagwat merged 2 commits intomasterfrom Feb 26, 2026
Merged
feat: FeastClient factory methods for pre-configured stubs#343vanitabhagwat merged 2 commits intomasterfrom
vanitabhagwat merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes:
overloads for timeout and credentials
master constructor that handles both ManagedChannel and stub cases
createSecure() methods
Which issue(s) this PR fixes:
Previously, FeastClient could only be instantiated with a
ManagedChannel, requiring users to manage channel lifecycle
directly. This prevented integration with libraries like
eg-spring-boot-clients that abstract channel management and
only expose pre-configured stubs via getClient() methods.
The new factory methods allow users to pass a ServingServiceBlockingStub
directly, enabling seamless integration with such libraries while
maintaining the existing API surface for backward compatibility.
Misc