feat: Add centralized rate limiter#305
Merged
vanitabhagwat merged 28 commits intomasterfrom Feb 27, 2026
Merged
Conversation
vanitabhagwat
changed the title
vanitabhagwat
changed the title
omirandadev
reviewed
Oct 20, 2025
Comment on lines
-300
to
-308
| # Leaving one core for operating system and other background processes | ||
| num_processes = num_spark_driver_cores - 1 | ||
|
|
||
| if table.num_rows < num_processes: | ||
| num_processes = table.num_rows | ||
|
|
||
| # Input table is split into smaller chunks and processed in parallel | ||
| chunks = self.split_table(num_processes, table) | ||
|
|
Collaborator
There was a problem hiding this comment.
Are you intentionally deleting the comments here? There are some comment deletions throughout.
Collaborator
Author
There was a problem hiding this comment.
It wasn't intentional. I ran the black and ruff formatting which probably did that. Added them back.
piket
reviewed
Oct 20, 2025
sdk/python/feast/rate_limiter.py
Outdated
Comment on lines
+34
to
+47
| backoff = 0.005 # initial minimal sleep | ||
| while not self.acquire(): | ||
| # Compute estimated sleep until oldest timestamp exits window. | ||
| # We use the current index position as the next candidate slot. | ||
| now = time.time() | ||
| with self._lock: | ||
| oldest_ts = self.timestamps[self.index] | ||
| remaining = oldest_ts + self.period - now | ||
| if remaining <= 0: | ||
| continue | ||
| # Sleep the smaller of remaining and a capped value to re-check frequently. | ||
| time.sleep(min(remaining, 0.05)) | ||
| # Optional exponential backoff (bounded) if still not free. | ||
| backoff = min(backoff * 2, 0.05) |
Collaborator
There was a problem hiding this comment.
It doesn't look like backoff is actually used anywhere, it's only recalculated. Is this meant to be part of the minimum sleep instead of the hardcoded 0.05?
omirandadev
reviewed
Oct 20, 2025
| entities_to_keep: Sequence[Entity], | ||
| partial: bool, | ||
| ): | ||
| # Call update only if there is an online store |
Collaborator
There was a problem hiding this comment.
Can you recomment this as well.
EXPEbdodla
reviewed
Jan 26, 2026
| out, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| log.Printf("Repo init error: %s", string(out)) | ||
| log.Fatal(err) |
Collaborator
There was a problem hiding this comment.
log.Fatal() calls os.exit(1) which will exit the test process. We need to use log.Printf()
EXPEbdodla
reviewed
Jan 26, 2026
EXPEbdodla
reviewed
Jan 26, 2026
Comment on lines
+221
to
+222
| percent_usage = 0.6 | ||
| interval = 1.0 # seconds |
Collaborator
There was a problem hiding this comment.
percent_usage -> Can we define this based on number of processors?
interval -> Good. We set is based on previous logic so no confusion here.
Co-authored-by: Bhargav Dodla <[email protected]>
Removed unnecessary blank lines in the integration test utility functions.
vanitabhagwat
force-pushed
the
ratelimiter
branch
from
5daad13 to
e2067c0
Compare
Co-Authored-By: Claude Opus 4.6 <[email protected]>
piket
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to create a more generic solution for write rate limiting that can be utilized by all online stores.