Support PHP 8.0#81
Merged
HeahDude merged 2 commits intoExercise:masterfrom Dec 28, 2020
pierres:patch-1
Merged
Conversation
Collaborator
|
Hello @pierres, many thanks for that PR! And happy holidays to you! Could you please try to declare "XDEBUG_MODE=coverage" using the |
Collaborator
|
Just noticed that the Xdebug issue is not caused by your changes, sorry. Thanks for working on it though. |
Contributor
Author
|
Yes, the Xdebug issue was unrelated and caused by the Xdebug 3 update. I rebased the PR to have two separate commits. |
Collaborator
|
Thank you @pierres for this nice contribution, 3.1 is now tagged :). Happy holidays! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.