Skip to content

Switch the Twig integration to use non-deprecated APIs#30

Merged
spolischook merged 1 commit into
Exercise:masterfrom
stof:patch-1
Aug 19, 2015
Merged

Switch the Twig integration to use non-deprecated APIs#30
spolischook merged 1 commit into
Exercise:masterfrom
stof:patch-1

Conversation

@stof

@stof stof commented Aug 19, 2015

Copy link
Copy Markdown
Contributor

This makes the bundle compatible with Twig 2.0 and avoids the deprecation warning in 1.21+

@spolischook

Copy link
Copy Markdown
Contributor

any broken BC?

@stof

stof commented Aug 19, 2015

Copy link
Copy Markdown
Contributor Author

@spolischook this requires Twig 1.12 to work. but symfony already depends on Twig 1.12 since years, and even on higher versions than that in latest releases (it will soon depend on 1.20+)

@spolischook

Copy link
Copy Markdown
Contributor

What last version of Symfony didn't works with this changes?

@stof

stof commented Aug 19, 2015

Copy link
Copy Markdown
Contributor Author

@spolischook all versions of Symfony work with the latest Twig 1.x version (Twig maintained BC strictly in the full 1.x lifetime).
Symfony 2.3.0 forced to have at least 1.12 for Twig, so people using Symfony 2.3+ are known to be safe. In older versions of Symfony, the min requirement for Twig was lower than that, bit the default version shipped in the SE was still the latest Twig release at that time.
So this can only break things for people who are using a totally unmaintained Symfony versions (2.2 is unmaintained since years, even for security patches) and have never updated their Twig version (which is possible even for them). Such people are unlikely to update the bundle to this version.

spolischook added a commit that referenced this pull request Aug 19, 2015
Switch the Twig integration to use non-deprecated APIs
@spolischook
spolischook merged commit 9e05932 into Exercise:master Aug 19, 2015
@spolischook

Copy link
Copy Markdown
Contributor

nice

@stof
stof deleted the patch-1 branch August 19, 2015 13:55
@XWB

XWB commented Aug 27, 2015

Copy link
Copy Markdown

@spolischook Is it possible to create a new tag (v0.2.1) ?

@spolischook

Copy link
Copy Markdown
Contributor

@XWB

XWB commented Aug 27, 2015

Copy link
Copy Markdown

Thank you very much!

@tgabi333

Copy link
Copy Markdown

Thanks

@tgabi333

Copy link
Copy Markdown

Could you please publish it to packagist too?

@stof

stof commented Aug 28, 2015

Copy link
Copy Markdown
Contributor Author

@spolischook you should configure the Packagist hook on the repo so that it happens automatically and quickly (instead of relying on the daily/weekly cron running for other packages)

@spolischook

Copy link
Copy Markdown
Contributor

Unfortunately have no access to configure this bundle. @wizardz has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants