v2.4 dev1 - mostly for construction layouts#58
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces version 2.4 dev1 with improvements primarily focused on construction layouts and workflow optimization. The changes modernize shell scripts, add file preparation capabilities for dispBDT training, and streamline parameter handling across the analysis pipeline.
Key changes:
- Added new shell script for separating dispBDT training files with configurable fractions
- Modernized multiple analysis scripts by updating shebangs and simplifying parameter handling
- Added PREPAREFILELISTS run mode for better file management workflow
- Updated telescope configuration and array definitions
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| utilities/removeUnreaseonablePhysFiles.sh | Added new file patterns for cleaning unreasonable physics files |
| prod6/subArray.prod6.NorthAlpha.list | Added new array configuration N.AmTS-4LSTs05MSTs |
| prod6/subArray.prod6.NorthAlpha-sub.list | Added corresponding sub-array configuration N.AmTS-0LSTs05MSTs |
| prod5/subArray.prod5.South-Beta.list | Removed S.BL-4LSTs25MSTs70SSTs-MSTF configuration |
| analysis/condorSubmission.sh | Fixed duplicate log file entry in submission script |
| analysis/CTA.separateDispTrainingEvndispFiles.sh | New script for separating training files with randomized selection |
| analysis/CTA.prepareTMVA.sub_train.sh | Modernized script with simplified parameter handling and file list management |
| analysis/CTA.TMVA.sub_train.sh | Updated to use bash and streamlined parameter processing |
| analysis/CTA.MSCW_ENERGY.sub_analyse_MC.sh | Simplified file list handling using pre-generated analysis lists |
| analysis/CTA.MSCW_ENERGY.qsub_analyse_MC.sh | Added telescope count detection and angle configuration |
| analysis/CTA.DISPTRAINING.sub_analyse.sh | Updated to use pre-separated training file lists |
| NIM-South.dat | Removed several telescope configurations |
| CTA.runAnalysis.sh | Added PREPAREFILELISTS run mode and updated analysis dates |
| CTA.mainRunScriptsReduced.sh | Added support for PREPAREFILELISTS mode with conditional directory creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.