Skip to content

ShapefileGeometryCursor sub-project created - #1

Merged
stolstov merged 3 commits into
Esri:masterfrom
willtemperley:master
Nov 15, 2016
Merged

stolstov merged 3 commits into
Esri:masterfrom
willtemperley:master

Conversation

@willtemperley

Copy link
Copy Markdown
Contributor

Shapefile reader added, with tests for the main shape types.

@randallwhitman

Copy link
Copy Markdown

Quick skim says this is a nice sample. Sergey can review the details.

@stolstov

Copy link
Copy Markdown
Member

@willtemperley Very nice!
I suggest adding to the test class an example that demonstrates a benefit from using this cursor:
For example,

GeometryCursor union_cursor = OperatorUnion.local().execute(new ShapefileGeometryCursor(polygon_file), null, null);
Geometry dissolved_geometry = union_cursor.next();

@willtemperley

Copy link
Copy Markdown
Contributor Author

@stolstov Cheers! Sure, I added a test for union as suggested and also buffering for good measure.

@stolstov

Copy link
Copy Markdown
Member

@willtemperley Great! Could you add the following license headers to both java files in your pull request?

/*
 Copyright 2016 Esri

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
 */

@willtemperley

Copy link
Copy Markdown
Contributor Author

Looking at the contribution guidelines it's stated:

Esri does not require you to assign the copyright of your contributions, you retain the copyright. Esri does require that you make your contributions available under the Apache license in order to be included in the main repo.

However the license header template does explicitly assign the copyright to Esri - would you be able to clarify please?

@randallwhitman

Copy link
Copy Markdown

@willtemperley

Copy link
Copy Markdown
Contributor Author

Thanks. Apache license headers added

@stolstov
stolstov merged commit c9d837c into Esri:master Nov 15, 2016
@stolstov

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants