Skip to content

Release notes for 1.7#536

Merged
AtmaMani merged 7 commits intoEsri:masterfrom
jyaistMap:jy-release-notes-17
Oct 30, 2019
Merged

Release notes for 1.7#536
AtmaMani merged 7 commits intoEsri:masterfrom
jyaistMap:jy-release-notes-17

Conversation

@jyaistMap
Copy link
Copy Markdown
Collaborator

@jyaistMap jyaistMap commented Oct 28, 2019

@DavidJVitale @AtmaMani

Added new samples and guides to release notes

Checklist

Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.

  • All imports are in the first cell? First block of imports are standard libraries, second block are 3rd party libraries, third block are all arcgis imports?
  • All GIS object instantiations are one of the following?
    • gis = GIS('https://www.arcgis.com', 'arcgis_python', 'P@ssword123')
    • gis = GIS(profile="your_online_profile")
    • gis = GIS('https://pythonapi.playground.esri.com/portal', 'arcgis_python', 'amazing_arcgis_123')
    • gis = GIS(profile="your_enterprise_portal")
  • If this notebook requires setup or teardown, did you add the appropriate code to ./misc/setup.py and/or ./misc/teardown.py?
  • If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api_data_owner user?
  • Code refactored & split out across multiple cells, useful comments?
  • Consistent voice/tense/narrative style? Thoroughly checked for typos?
  • All images used like <img src="base64str_here"> instead of <img src="https://some.url">? All map widgets contain a static image preview? (Call mapview_inst.take_screenshot() to do so)
  • All file paths are constructed in an OS-agnostic fashion with os.path.join()? (Instead of r"\foo\bar", os.path.join(os.path.sep, "foo", "bar"), etc.)
  • IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE, ping @ DavidJVitale so he can add it to the list for the next deploy

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Copy link
Copy Markdown
Contributor

@AtmaMani AtmaMani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyaistMap I suggested some changes to page titles in https://github.com/ArcGIS/arcgis-for-developers/pull/9023. Along those lines, could you make the following changes

  1. remove 'perform analysis (out of hte box tools)
  2. rename ortho mapping pages to Orthomapping (part 1) to Orthomapping part 1 - creating image collections
    rename Orthomapping (part2) to Orthomapping part 2 - generating elevation models
    rename Orthomapping (part3) to Orthomapping part 3 - managing image collections.
  3. rename 'feature categorization' to 'Categorizing features using arcgis.learn'.
  4. rename 'Analyzing NYC growth..' to 'Analyzing growth factors of rental properties in New York City'

@jyaistMap
Copy link
Copy Markdown
Collaborator Author

@AtmaMani
Sure! I issued PR #9028 for all the changes in the dev repo.

@AtmaMani AtmaMani merged commit e39b3ee into Esri:master Oct 30, 2019
@jyaistMap jyaistMap deleted the jy-release-notes-17 branch January 20, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants