Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OniOni/python-parallel-wd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: EliAndrewC/python-parallel-wd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 15, 2013

  1. Update parallel.py 

    When I try to run

self.assertEqual(x, y)

in one of my tests, it fails with the error

AttributeError: 'SubTest' object has no attribute '_type_equality_funcs'

This is because we never call TestCase.__init__ in the SubTest.__init__, and according to the docstring, "If it is necessary to override the __init__ method, the base class __init__ method must always be called." (you can see this by running "pydoc unittest.TestCase")

TestCase.__init__ expects to be passed a string which is the name of the method being tested; this will fail if you pass a non-existing method name.  Unfortunately, we're manually constructing SubTest and then passing that as the "self" to our real test case method, defined elsewhere, so we can't use that method's name.  Fortunately, it's okay if we don't pass the real method name, so long as we pass any method name that is known to exist; I use "__init__" since that will always exist.
    @EliAndrewC
    EliAndrewC committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    2871f63 View commit details
    Browse the repository at this point in the history

  2. Update parallel.py 

    fixed typo from previous commit
    @EliAndrewC
    EliAndrewC committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    a1f4dc7 View commit details
    Browse the repository at this point in the history
Loading