Repository navigation
PR практика 1 - #1
Open
ElenaPupysheva wants to merge 5 commits into
Open
ElenaPupysheva wants to merge 5 commits into
ElenaPupysheva wants to merge 5 commits into
Conversation
Comment on lines
+2
to
+3
| String name; | ||
| int speed; |
There was a problem hiding this comment.
🍏 эти переменные лучше пометить как final. С помощью final отмечаются переменные, которые инициализируются только один раз.
| int speed; | ||
| while (true) { | ||
| speed = scanner.nextInt(); | ||
| if ((speed > 0) && (speed <= 250)) { |
There was a problem hiding this comment.
🍏 максимальную и минимальную скорость можно вынести в константы
| } | ||
| } | ||
| System.out.println("Гонка завершена!"); | ||
| for (Car car : carList) System.out.println("В гонке участвовали: "+car.name+" со скоростью " +car.speed+ " км/ч"); |
There was a problem hiding this comment.
🍏 лучше все-таки открыть фигурные скобки и написать System.out.println на следующей строчке, так код будет более читаем
Comment on lines
+5
to
+6
| // ваш код начнется здесь | ||
| // вы не должны ограничиваться только классом Main и можете создавать свои классы по необходимости |
There was a problem hiding this comment.
🍏 ненужные комментарии можно смело удалять)
|
Оставлю на будущее гайд по работе с ветками: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлено решение первой практической работы.