Repository navigation
Update to Poetry to 1.1.0+ #112
Description
Upgrading to poetry 1.1.0 causes an issue.Particularly, gmpy=2.0.8 will fail on install. This seems to be related exclusively to the poetry version.
This can be tested locally by installing:
pip install poetry 1.1.0
and running make environment:
make environment
The expected resolution would be either waiting for a bug fix from poetry or figuring out exactly why gmpy2 won't install.
Activity
Davidy22 commentedon Oct 2, 2021
I pulled the repo real quick to take a crack at dealing with this, went into Dockerfile and Makefile and I see that the pip install lines have already been changed to grab poetry=1.1.6.
make environmentalso worked for me, so I suspect this issue has been resolved in the churn of time and upstream changes. During research, I noticed poetry's incremented to 1.1.10, so I did a quick bump and tried it out and that worked locally.Just going to register a trial azure account real quick so I can see if CI on github passes, but I feel like the difference between 1.1.6 and 1.1.10 isn't going to be hugely breaking. Also, I suspect once I get my azure credentials plugged in that CI on my repository is going to halt at the same step that all the builds since 7ce6992 have been failing on, I could see what I can do there if that's something we want dealt with and no one else is handling it.
keithrfung commentedon Oct 6, 2021
@david22 A little late replying to this but that sounds great if it's a simple change. Originally we had more problems because I believe one of the versions of poetry had a cache issue. I will assign.
Davidy22 commentedon Oct 6, 2021
I mean, this specific issue I think is actually already resolved, the version number for poetry that I found in master is 1.1.6, which is well past the 1.1.0 that gave you trouble on 2 October 2020. I can bump the version number to 1.1.10, but you probably didn't need my help to do that. Actually, the only step I think I need to do is finish getting my azure trial account set up so I can run CI and confirm that 1.1.10 doesn't break anything but it's just a bugfix release in the 1.1.x series and probably innocent.