Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lindar-open/fe-code-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: ElWildo/fe-code-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 15 files changed
  • 1 contributor

Commits on Oct 23, 2024

  1. #1 - Update card grid style

    - Add style import in SymbolView
    - Add style for symbolView Content and symbolView Cards
    - Add style import in SymbolGrid
    - Add style for symbolView Cards
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c78c2ad View commit details
    Browse the repository at this point in the history
  2. #2 - Update card header

    - Extrat trend element and make it a component
    - Add Trend Component to header for the card
    - Add style for the trend icon
    - Update card header style
    - Fix file name to match naming convention
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5ac8bb0 View commit details
    Browse the repository at this point in the history
  3. #2 - Update card Item List

    - Add industry and cap marked list element in SymbolCard
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ea21878 View commit details
    Browse the repository at this point in the history
  4. #2 - Format Money Values

    - Add formatter to Symbol Card
    - Update monetary values to be formatted
    - Add style for the price row
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f3000a9 View commit details
    Browse the repository at this point in the history
  5. #2 - Format Card Container

    - Update SymbolsView structure
    - Update SymbolsView style
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    cd5fc3a View commit details
    Browse the repository at this point in the history
  6. #2 - Format Card Container for undefined prices

    - Update Fromatted Price to display - for empty price values
    - Update SymbolCard to display - for empty pricevalues
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2b329e7 View commit details
    Browse the repository at this point in the history
  7. #6 - Implement more info functionality

    - Add show card info state to card grid
    - Add  card info view props to symbol card and use it to make extra info conditional
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    671d8a4 View commit details
    Browse the repository at this point in the history
  8. #7 - Implement animation on itneraction

    - Add conditional box shadow
    - Add conditional growing/shrinking animation
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1d21bef View commit details
    Browse the repository at this point in the history
  9. #8 - Shake Animation

    - Add shake animation
    - Add previous value hook
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b73257f View commit details
    Browse the repository at this point in the history
  10. #9 - Add Glow

    - Add shake animation
    - Add previous value hook
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e943226 View commit details
    Browse the repository at this point in the history
  11. #10 - Add Glow

    - Add wait for fetchPriceHistory to handle the race condition
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1f1a574 View commit details
    Browse the repository at this point in the history
  12. #11 - Add Glow

    - Add media query for mobile
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8edfb5f View commit details
    Browse the repository at this point in the history
  13. #12 - Fix glow animation

    - Update glow animation style
    - Move glow state managment to symbol card
    - Update buse previous hook
    elWildo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d6a8971 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. #13 - Fix glow animation

    - Add action to reducer for active simbol
    - Update selected symbol state to be a redux state
    - Update SymbolCard to work with the new selected Active symbol state
    - Update fix race condition
    elWildo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e4b446b View commit details
    Browse the repository at this point in the history
  2. #13 - Fix glow animation

    - Add card deselection
    elWildo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1b1511e View commit details
    Browse the repository at this point in the history
Loading