Skip to content

add 0000-01-02-EdgarNigel.md - #3

Merged
EdgarNigel merged 2 commits into
masterfrom
philipp
Oct 17, 2018
Merged

add 0000-01-02-EdgarNigel.md#3
EdgarNigel merged 2 commits into
masterfrom
philipp

Conversation

@EdgarNigel

@EdgarNigel EdgarNigel commented Oct 17, 2018

Copy link
Copy Markdown
Owner

I created a branch, a file and made a comment.

@github-learning-lab github-learning-lab Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

Let's edit this pull request to add a body description.

⌨️ Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click on the pencil icon located at the top right corner of the comment box to make an edit
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


Watch below for my response

I created a branch, a file and made a comment.

@github-learning-lab github-learning-lab Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 7: Respond to a review

Your pull request is looking great!

Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdown is supported.

⌨️ Activity: Change your file

  1. Click the "Files Changed" tab in this pull request
  2. Click on the pencil icon found on the right side of the screen
  3. Replace line 5 with something new
  4. Scroll to the bottom and click Commit Changes

Watch below for my response

@github-learning-lab github-learning-lab Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Merge your pull request

Nicely done @EdgarNigel! ✨

You successfully created a pull request, and it has passed all of the tests. You can now merge your pull request.

⌨️ Activity: Merge the pull request

  1. Click Merge pull request
  2. Click Confirm merge
  3. Once your branch has been merged, you don't need it anymore. Click Delete branch.

Watch below for my response

@github-learning-lab

Copy link
Copy Markdown

Nice work

celebrate

Congratulations @EdgarNigel, you've completed this course!

What went well

Now, you have your slide deck deployed here and you've gone through the GitHub Flow.

Before I say good-bye, here's a recap of all the tasks you've accomplished in your repository:

  • You learned about issues, pull requests, and the structure of a GitHub repository
  • You learned about branching
  • You created a commit
  • You viewed and responded to pull request reviews
  • You edited an existing file
  • You enabled GitHub Pages
  • You made your first contribution! 🎉

What's next?

We hope this course helped you feel more comfortable using GitHub. Remember: You’re always welcome to repeat course topics if you’d like additional practice. If you’re ready to build on your new skills, here are some ideas.

Contribute to a project

To find projects to contribute to through trending topics and curated collections, check out GitHub Explore.

Keep learning

Check out the other GitHub Learning Lab courses in your Dashboard! What will you learn next?

@EdgarNigel
EdgarNigel merged commit fb3dd24 into master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant