Skip to content

feat: add example1#1

Merged
FacerAin merged 2 commits into
devfrom
feat/example
Nov 9, 2022
Merged

feat: add example1#1
FacerAin merged 2 commits into
devfrom
feat/example

Conversation

@FacerAin

@FacerAin FacerAin commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

Description

  • Add example1 for testing

Related Issue

  • No Related Issues

* add example1 for testing
@FacerAin FacerAin added the enhancement New feature or request label Nov 9, 2022
@FacerAin FacerAin requested review from ghlrobin and wbin0718 November 9, 2022 06:36
@FacerAin

FacerAin commented Nov 9, 2022

Copy link
Copy Markdown
Contributor Author

#1

Comment thread example/example1.py Outdated

@jinmyeongAN jinmyeongAN left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much good!

Comment thread example/example1.py Outdated

@ghlrobin ghlrobin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall, but check my review

Comment thread .pre-commit-config.yaml
Comment thread .pre-commit-config.yaml
Comment thread .pre-commit-config.yaml
@ghlrobin ghlrobin self-requested a review November 9, 2022 07:55

@kyc3492 kyc3492 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goooooooood

@jinmyeongAN jinmyeongAN self-requested a review November 9, 2022 07:56
@FacerAin FacerAin merged commit 1773465 into dev Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants