Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added ruleset for nachdenkseiten.de#9941

Closed
BlauerHunger wants to merge 1 commit intoEFForg:masterfrom
BlauerHunger:master
Closed

Added ruleset for nachdenkseiten.de#9941
BlauerHunger wants to merge 1 commit intoEFForg:masterfrom
BlauerHunger:master

Conversation

@BlauerHunger
Copy link
Copy Markdown

No description provided.


<rule from="^http:" to="https:" />

<securecookie host="nachdenkseiten.de" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is invalid. Please have a look at our documentation.

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Dec 5, 2017

@BlauerHunger Are you still interested in working on this pull request?

@BlauerHunger
Copy link
Copy Markdown
Author

If this has a chance of getting merged, yes. I don't have much time at the moment, but if there are some change requests from your side, please tell me.

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Dec 5, 2017

@BlauerHunger The main problem with HTTPS on this site is mixed content blocking, which is what makes the content at https://www.nachdenkseiten.de/ look broken/badly styled. Search our CONTRIBUTING.md for "mixedcontent" for more information about that.

If you're okay with a "mixedcontent" ruleset, which effectively means the ruleset will be disabled by default on all browsers except Tor, then:

  • Change your ruleset to look like this:
<ruleset name="Nachdenkseiten.de" platform="mixedcontent">
	<target host="nachdenkseiten.de" />
	<target host="www.nachdenkseiten.de" />

	<rule from="^http:" to="https:" />
</ruleset>

Otherwise, please close this pull request. Please let me know if you have any questions.

@jeremyn jeremyn self-assigned this Dec 5, 2017
@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Dec 18, 2017

@BlauerHunger Can we move forward on this one?

@BlauerHunger
Copy link
Copy Markdown
Author

BlauerHunger commented Dec 22, 2017

I just wanted to work on this and I noticed that it nachdenkseiten.de has changed in a way that it now needs mixed content to work (when I created this PR, a accept mixed content request popped up, but the site worked without problems although ignoring this).

I think I'll ask the webmaster of nachdenkseiten.de to fix their HTTPS before continuing to work on this

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Dec 22, 2017

@BlauerHunger Thanks for the update.

@jeremyn jeremyn removed their assignment Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants