This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Create ruleset: Elgas.com.au#15772
Merged
J0WI merged 3 commits intoEFForg:masterfrom Jun 28, 2018
injust:patch-217
Merged
Conversation
J0WI
reviewed
Jun 16, 2018
| <ruleset name="Elgas.com.au"> | ||
| <target host="elgas.com.au" /> | ||
| <target host="www.elgas.com.au" /> | ||
| <target host="emap.elgas.com.au" /> |
Contributor
Author
There was a problem hiding this comment.
That host fails the CI build, because accessing it on HTTP redirects to www.secure.elgas.com.au, which DNE.
Maybe the Travis tests should be modified to allow for sites that only work on HTTPS?
Contributor
There was a problem hiding this comment.
The problem here is that HTTP serves a different response than HTTPS. Could you document the issue?
Contributor
Author
There was a problem hiding this comment.
I've added a comment for secure.elgas.com.au.
In this case, would it be better to leave the target out of the ruleset, or include it and whitelist the ruleset against fetch tests?
Contributor
There was a problem hiding this comment.
I don't know what the expected behavior would be in this case. I'm fine with both variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.