This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Update aastocks.com.xml#15605
Merged
J0WI merged 8 commits intoEFForg:masterfrom Jun 17, 2018
cschanaj:aastocks.com
Merged
Conversation
Do not force HTTPS on the homepage as this break the "Real-time Latest Quote" functionality
ghost
suggested changes
Jun 6, 2018
| --> | ||
| <ruleset name="AASTOCKS.com (partial)"> | ||
| <target host="www.aastocks.com" /> | ||
| <exclusion pattern="^http://www\.aastocks\.com/(tc|sc|en)/$" /> |
There was a problem hiding this comment.
Put all exclusions after a rule they apply to.
| <target host="fctdata.aastocks.com" /> | ||
| <target host="fpdata.aastocks.com" /> | ||
| <target host="fxcharts.aastocks.com" /> | ||
| <!-- target host="fpdata.aastocks.com" / --> |
There was a problem hiding this comment.
Simply remove the lines you commented out.
| to="https://hkg3.aastocks.com/" /> | ||
|
|
||
| <rule from="^http:" | ||
| to="https:" /> |
| @@ -143,5 +141,9 @@ | |||
| <securecookie host="logon\.aastocks\.com" name=".+" /> | |||
| <securecookie host="secure\.aastocks.com" name=".+" /> | |||
There was a problem hiding this comment.
<securecookie host="(logon|secure)\.aastocks.com" name=".+" />
Collaborator
Author
|
@YegorIevlev AFAIK, the current practice is to put the |
ghost
approved these changes
Jun 7, 2018
J0WI
reviewed
Jun 16, 2018
|
|
||
| <rule from="^http:" to="https:" /> | ||
| <rule from="^http://hkg1?\.aastocks\.com/" | ||
| to="https://hkg3.aastocks.com/" /> |
Contributor
There was a problem hiding this comment.
Could you add a test url for this?
J0WI
reviewed
Jun 16, 2018
| <ruleset name="AASTOCKS.com (partial)"> | ||
| <target host="www.aastocks.com" /> | ||
| <exclusion pattern="^http://www\.aastocks\.com/(tc|sc|en)/$" /> | ||
| <exclusion pattern="^http://www\.aastocks\.com/(tc|sc|en)/.+\.as[hp]x" /> |
Contributor
There was a problem hiding this comment.
Please add a hint about the issues there.
added 2 commits
June 17, 2018 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.