Create ruleset: Mono project and pronoun.is#15535
Conversation
|
I suppose that the CI breaking issue is not my fault? |
| @@ -0,0 +1,5 @@ | |||
| <ruleset name="Mono project"> | |||
| <target host="www.mono-project.com" /> | |||
There was a problem hiding this comment.
mono-project.com
download.mono-project.com
origin-download.mono-project.com
news.mono-project.com
jenkins.mono-project.com
There was a problem hiding this comment.
https://mono-project.com and https://news.mono-project.com/ are not available. Please verify.
| @@ -0,0 +1,5 @@ | |||
| <ruleset name="pronoun.is"> | |||
| <target host="pronoun.is" /> | |||
There was a problem hiding this comment.
www.pronoun.is
hubots.pronoun.is
my.pronoun.is
There was a problem hiding this comment.
I don’t think these domains are available in HTTPS.
There was a problem hiding this comment.
@FranklinYu Then add information about that as a comment.
| @@ -0,0 +1,5 @@ | |||
| <ruleset name="Mono project"> | |||
| <target host="www.mono-project.com" /> | |||
|
|
|||
| @@ -0,0 +1,5 @@ | |||
| <ruleset name="pronoun.is"> | |||
| <target host="pronoun.is" /> | |||
|
|
|||
|
@YegorIevlev Sorry for late reaction. I didn’t know about the rules for non-working hosts. I updated those two files. |
| Invalid certificate: | ||
| hubots.pronoun.is | ||
| my.pronoun.is | ||
| www.pronoun.is |
There was a problem hiding this comment.
It seems that this host has a wildcard DNS. Could you add a comment about this?
Since my and www serve the same content as ^ we can secure them by redirecting to ^.
| @@ -0,0 +1,15 @@ | |||
| <!-- | |||
| Invalid certificate: | |||
| mono-project.com | |||
|
Please push each ruleset in a separate PR for future contributions. 😃 |
FranklinYu
force-pushed
the
rules/1
branch
2 times, most recently
from
859497e to
c894a46
Compare
|
I don’t think I fully understand why the build fails… |
|
Please have a look at https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#ruleset-style-guide
|
|
? I thought I was asked to do the redirection? |
|
Yes, but please only for |
|
Hopefully this would make witch-house/pronoun.is#42 better… |
| Mismatch: | ||
| hubots.pronoun.is | ||
| my.pronoun.is | ||
| www.pronoun.is |
There was a problem hiding this comment.
Please document that this host has a wildcard DNS record.
LGTM otherwise.
|
Got the line from https-everywhere/src/chrome/content/rules/PDFMerge.com.xml Lines 1 to 3 in 2033759 |
3 participants
Two simple rulesets for simple websites.