This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Add "Reset to Defaults" Option in Popup UI, Fix #10004#15411
Merged
Hainish merged 8 commits intoEFForg:masterfrom May 24, 2018
cschanaj:refractor-rules-js
Merged
Add "Reset to Defaults" Option in Popup UI, Fix #10004#15411Hainish merged 8 commits intoEFForg:masterfrom cschanaj:refractor-rules-js
Hainish merged 8 commits intoEFForg:masterfrom
cschanaj:refractor-rules-js
Conversation
Collaborator
Author
|
@Hainish would you have a look on this? |
Hainish
suggested changes
May 21, 2018
Member
Hainish
left a comment
Hainish
left a comment
There was a problem hiding this comment.
Thanks for this @cschanaj. A few comments:
- I would have the "Reset to Defaults" link appear below the rules sections.
- I would have a confirmation dialogue appear. It's too easy to click this accidentally.
- I would close the menu once it is clicked. With the current functionality, the page reloads with the popup still open, and you have to close it and open it again to see the changes reflected.
Collaborator
Author
|
@Hainish corresponding changes are made. thanks!! |
Hainish
approved these changes
May 24, 2018
Member
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @Hainish
Steps:
Github, refresh page to make sure that ruleset is disabledGithubis enabled.BTW, it looks like that Travis
seleniumtests fail frequently these days, e.g. https://travis-ci.org/EFForg/https-everywhere/jobs/378370329; not sure if #15396 helps, though...