Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

typescriptlang.org#15240

Merged
J0WI merged 5 commits intoEFForg:masterfrom
theel0ja:patch-4
Jul 1, 2018
Merged

typescriptlang.org#15240
J0WI merged 5 commits intoEFForg:masterfrom
theel0ja:patch-4

Conversation

@theel0ja
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tabs instead of spaces.

@@ -0,0 +1,6 @@
<ruleset name="typescriptlang.org">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add typescriptlang.org which can be redirected to www.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding the target won't work here, since typescriptlang.org does not support https. It needs to be redirected to https://www.typescriptlang.org/ explicitly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what should I do?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add <rule from="^http://typescriptlang\.org/" to="https://www.typescriptlang.org/" /> before <rule from="^http:" to="https:" />.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a short comment about the issue on https://typescriptlang.org/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, copied yours

@J0WI J0WI merged commit a03f554 into EFForg:master Jul 1, 2018
@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Jul 1, 2018

Thanks!

@theel0ja theel0ja deleted the patch-4 branch July 2, 2018 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants