Repository navigation
Conversation
Implement comprehensive external webhook system that sends earthquake data to external services with both raw string data and processed DTOs: - Add ExternalData interface with getDataType, toExternalDto, and getRawData methods - Create EEWExternalData and QuakeInfoExternalData DTOs with same info level as Discord embeds - Add EEWDataWrapper to properly handle DmdataEEW external data - Extend ExternalWebhookRequest with eewbot field for processed data - Update ExternalWebhookService to send raw data in data field and DTO in eewbot field - Add rawData support to DmdataEEW and AbstractJMAReport classes - Integrate external webhook calls in EEWExecutor alongside Discord messaging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Update dependency ch.qos.logback:logback-classic to v1.5.22
Update alpine Docker tag to v3.23.2
…s.client5.httpclient5 Update dependency org.apache.httpcomponents.client5:httpclient5 to v5.6
Update dependency ch.qos.logback:logback-classic to v1.5.23
External webhook
Update wire to v5.5.1
Update docker/build-push-action action to v7
Update docker/metadata-action action to v6
Update flyway to v12.1.0
…nd field' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…nd field' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Feat/tsunami
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70cba5401f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| public RendererQueryFactory(String baseURL, String hmacKey) { | ||
| if (StringUtils.isEmpty(baseURL) || StringUtils.isEmpty(hmacKey)) { | ||
| if (baseURL == null || StringUtils.isEmpty(hmacKey)) { |
There was a problem hiding this comment.
The constructor now only checks baseURL == null, so a config with renderer.address set to an empty string and a non-empty key is considered available. In that case generateURL(...) builds URLs like "/" + payload, which are invalid image URLs and cause rendered-map embeds to break whenever quake/tsunami rendering is attempted under this configuration. The availability guard should reject empty/blank base URLs as well.
Useful? React with 👍 / 👎.
2 participants
No description provided.