This repository was archived by the owner on Jan 14, 2018. It is now read-only.
Explicitly declare the top, left, right controller ivars as protected#282
Merged
enriquez merged 1 commit intoECSlidingViewController:masterfrom Feb 5, 2014
jeffbailey:master
Merged
Explicitly declare the top, left, right controller ivars as protected#282enriquez merged 1 commit intoECSlidingViewController:masterfrom jeffbailey:master
enriquez merged 1 commit intoECSlidingViewController:masterfrom
jeffbailey:master
Conversation
…d underRightViewController ivars as protected so a subclass of ECSlidingViewController has access. This change was needed in order to provide a custom transition when changing the topViewController.
enriquez
added a commit
that referenced
this pull request
Feb 5, 2014
Explicitly declare the top, left, right controller ivars as protected
Member
|
Thanks @jeffbailey |
Author
|
Thanks Mike! Appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly declare the topViewController, underLeftViewController, and underRightViewController ivars as protected so a subclass of ECSlidingViewController has access.
This change was needed in order to provide a custom transition when changing the topViewController. We need to provide an alternate way (i.e. shortcut) for our app to navigate from one top view controller to another one. In particular, the current top view controller has a button that when tapped will transition directly to a new top controller. If we just called the setTopViewController method then we would not have the ability to provide our own animation (e.g. cross dissolve) from the current top controller to the new one. With this change we were able to subclass ECSlidingViewController and add the following method: