Increase unit test coverage in package "core"#50
Merged
Conversation
stefaneberl
requested changes
Feb 5, 2018
Contributor
There was a problem hiding this comment.
Feedback regarding tests:
- Please remove the "test" prefix from method names, since in the past @thomasgrassauer and I agreed to leave this out. Reason - The classes themselves already do contain the Test word in them and therefore this info is redundant.
Other than that there are several minor comments which are only intended as information about some shortcut methods.
|
|
||
| // create a valid session | ||
| final Session session = openKit.createSession("127.0.0.1"); | ||
| assertThat(session, not(nullValue())); |
Contributor
There was a problem hiding this comment.
org.hamcrest.Matchers.notNullValue -> mean it can be used like
assertThat(session, notNullValue());|
|
||
| // User has forgotten to initialize => shall not throw an exception | ||
| final Session session = openKit.createSession("127.0.0.1"); | ||
| assertThat(session, not(nullValue())); |
Contributor
There was a problem hiding this comment.
assertThat(session, notNullValue());| final SessionImpl session2impl = (SessionImpl)session2; | ||
|
|
||
| // verify that the two sessions exist and are not the same | ||
| assertThat(session1impl, not(session2impl)); |
Contributor
There was a problem hiding this comment.
I guess it would make sense to test for
assertThat(session1impl, not(sameInstance(session2impl)));This makes clear, that both variables shall not be the same instance.
| assertThat(session1impl, not(session2impl)); | ||
| } | ||
|
|
||
| private Configuration createTestConfig() { |
Contributor
There was a problem hiding this comment.
I guess this could be a setUp method
|
|
||
| // child leaves immediately | ||
| final Action retAction = childAction.leaveAction(); | ||
| assertThat(retAction, is(equalTo((Action) rootAction))); |
Contributor
There was a problem hiding this comment.
assertThat(retAction, is(sameInstance(rootAction)));|
|
||
| // test the constructor call | ||
| final WebRequestTracerURLConnection conn = new WebRequestTracerURLConnection(beacon, action, urlConnection); | ||
| assertThat(conn, not(nullValue())); |
Contributor
There was a problem hiding this comment.
assertThat(conn, notNullValue());|
|
||
| // verify that the tag is now set | ||
| existingTag = urlConnection.getRequestProperty(OpenKitConstants.WEBREQUEST_TAG_HEADER); | ||
| assertThat(existingTag, not(nullValue())); |
Contributor
There was a problem hiding this comment.
assertThat(existingTag, notNullValue());| assertThat(session.isEmpty(), is(true)); | ||
| } | ||
|
|
||
| private Beacon createTestBeacon() { |
Contributor
There was a problem hiding this comment.
method can be made static
|
|
||
| // verify the correct methods being called | ||
| verify(beaconSender, times(1)).startSession(eq(session)); | ||
| verify(beacon, times(1)).reportCrash(eq(errorName), eq(reason), eq(stacktrace)); |
Contributor
There was a problem hiding this comment.
small info: AFAIK the eq() are not necessary in this case
| retAction = rootAction.leaveAction(); | ||
| assertThat(retAction, is(nullValue())); | ||
|
|
||
| // verify that beacon cache is now empty |
Contributor
There was a problem hiding this comment.
// verify that open child actions are now empty
openkitdt
pushed a commit
that referenced
this pull request
Jul 17, 2019
…e-1.3.3 to release/1.3 * commit '9223f63d72824a5a05a05b6cb41eb3777c7171a9': Prepare to release version 1.3.3 GitOrigin-RevId: 776b7a33897fb3bd6e7fc68cb63ef5cce65876b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.