Hide slug box by default. Allow turning it on via screen options. fixes WordPress#8332

ryanboren · ryanboren · commit 46e0dfd13fa1 · 2008-11-28T22:35:01.000Z
git-svn-id: https://develop.svn.wordpress.org/trunk@9956 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/wp-admin/edit-form-advanced.php b/wp-admin/edit-form-advanced.php
@@ -434,7 +434,7 @@ function post_comment_status_meta_box($post) {
 </table>
 <p class="hide-if-no-js"><a href="#commentstatusdiv" id="show-comments" onclick="commentsBox.get(<?php echo $total; ?>);return false;"><?php _e('Show comments'); ?></a> <img class="waiting" style="display:none;" src="images/loading.gif" alt="" /></p>
 <?php
-	$hidden = (array) get_user_option( "meta-box-hidden_post", 0, false );
+	$hidden = get_hidden_meta_boxes('post');
 	if ( ! in_array('commentstatusdiv', $hidden) ) { ?>
 		<script type="text/javascript">commentsBox.get(<?php echo $total; ?>, 10);</script>
 <?php
diff --git a/wp-admin/includes/template.php b/wp-admin/includes/template.php
@@ -2718,7 +2718,7 @@ function do_meta_boxes($page, $context, $object) {
 
 	//do_action('do_meta_boxes', $page, $context, $object);
 
-	$hidden = (array) get_user_option( "meta-box-hidden_$page", 0, false );
+	$hidden = get_hidden_meta_boxes($page);
 
 	echo "<div id='$context-sortables' class='meta-box-sortables'>\n";
 
@@ -2798,7 +2798,7 @@ function meta_box_prefs($page) {
 	if ( empty($wp_meta_boxes[$page]) )
 		return;
 
-	$hidden = (array) get_user_option( "meta-box-hidden_$page", 0, false );
+	$hidden = get_hidden_meta_boxes($page);
 
 	foreach ( array_keys($wp_meta_boxes[$page]) as $context ) {
 		foreach ( array_keys($wp_meta_boxes[$page][$context]) as $priority ) {
@@ -2817,6 +2817,20 @@ function meta_box_prefs($page) {
 	}
 }
 
+function get_hidden_meta_boxes($page) {
+	$hidden = (array) get_user_option( "meta-box-hidden_$page", 0, false );
+
+	// Hide slug boxes by default
+	if ( empty($hidden[0]) ) {
+		if ( 'page' == $page )
+			$hidden = array('pageslugdiv');
+		elseif ( 'post' == $page )
+			$hidden = array('slugdiv');
+	}
+
+	return $hidden;
+}
+
 /**
  * Add a new section to a settings page.
  *
diff --git a/wp-admin/js/page.js b/wp-admin/js/page.js
@@ -7,9 +7,6 @@ jQuery(document).ready( function($) {
 
 	jQuery('#title').blur( function() { if ( (jQuery("#post_ID").val() > 0) || (jQuery("#title").val().length == 0) ) return; autosave(); } );
 
-	// hide advanced slug field
-	jQuery('#pageslugdiv').hide();
-
 	var stamp = $('#timestamp').html();
 
 	var visibility = $('#post-visibility-display').html();
diff --git a/wp-admin/js/post.js b/wp-admin/js/post.js
@@ -107,9 +107,6 @@ jQuery(document).ready( function($) {
 	// Editable slugs
 	make_slugedit_clickable();
 
-	// hide advanced slug field
-	jQuery('#slugdiv').hide();
-
 	jQuery('#tags-input').hide();
 	tag_update_quickclicks();
 	// add the quickadd form
diff --git a/wp-includes/script-loader.php b/wp-includes/script-loader.php
@@ -173,7 +173,7 @@ function mce_version() {
 			'save' => __('Save'),
 			'cancel' => __('Cancel')
 		) );
-		$scripts->add( 'post', '/wp-admin/js/post.js', array('suggest', 'jquery-ui-tabs', 'wp-lists', 'postbox', 'slug'), '20081112b' );
+		$scripts->add( 'post', '/wp-admin/js/post.js', array('suggest', 'jquery-ui-tabs', 'wp-lists', 'postbox', 'slug'), '20081128' );
 		$scripts->localize( 'post', 'postL10n', array(
 			'tagsUsed' =>  __('Tags used on this post:'),
 			'add' => attribute_escape(__('Add')),
@@ -198,7 +198,7 @@ function mce_version() {
 			'privatelyPublished' => __('Privately Published'),
 			'published' => __('Published')
 		) );
-		$scripts->add( 'page', '/wp-admin/js/page.js', array('jquery', 'slug', 'wp-lists', 'postbox'), '20081112' );
+		$scripts->add( 'page', '/wp-admin/js/page.js', array('jquery', 'slug', 'wp-lists', 'postbox'), '20081128' );
 		$scripts->localize( 'page', 'postL10n', array(
 			'cancel' => __('Cancel'),
 			'edit' => __('Edit'),
