Skip to content

Enable case-insensitive tab completion for files and folders on case-sensitive filesystem - #8128

Merged
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
SteveL-MSFT:case-insensitive-completion
Oct 28, 2018
Merged

Enable case-insensitive tab completion for files and folders on case-sensitive filesystem#8128
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
SteveL-MSFT:case-insensitive-completion

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Oct 26, 2018

Copy link
Copy Markdown
Member

PR Summary

Leverage new EnumerationOption in .NET Core 2.1 to have case-insensitive enumeration of files and folders. Allows for case-insensitive tab completion of files and folders on a case-sensitive filesystem.

#1273

PR Checklist

need to explicitly have enumoptions not skip hidden/system files to retain existing behavior

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated
}

It "Test case insensitive folder path" -Skip:(!$IsLinux) {
$testDirs = "AA", "Aa", "aa"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could check dirs in previous test with files.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Outdated
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated
@iSazonov
Ilya (iSazonov) merged commit b27380d into PowerShell:master Oct 28, 2018
@iSazonov

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Should we close #1273?

@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the case-insensitive-completion branch October 28, 2018 06:17
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants