Skip to content

Created branches dev and branch_model and in the branch_model added c… - #1

Open
DmitryHV wants to merge 1 commit into
devfrom
branch_model
Open

DmitryHV wants to merge 1 commit into
devfrom
branch_model

Conversation

@DmitryHV

Copy link
Copy Markdown
Owner

Good evening!
Please check this task.
Thanks.

@DmitryHV
DmitryHV requested a review from RomanKashenok August 26, 2020 20:56
Comment thread Library/src/Author.java
public class Author {
String firstName;
String lastName;
String[] arrayBooks;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's array of books, why do you create array of Strings?

Comment thread Library/src/Book.java
int yearPublishing;
String title;
String author;
String genre;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genre field should be of type Genre, but not String

Comment thread Library/src/Book.java
public class Book {
int yearPublishing;
String title;
String author;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

author field should be of type Author, but not String

Comment thread Library/src/Library.java
@@ -0,0 +1,8 @@
public class Library {
String[] books;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's array of books, why do you create array of Strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants