Repository navigation
DPI-5056: Skip cloud tests instead of aborting when offline - #27
Draft
instantepiphany wants to merge 1 commit into
Draft
instantepiphany wants to merge 1 commit into
instantepiphany wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/testthat/helper-skip.Rcallsrversions::r_release()while the test helpers load, which fetches from svn.r-project.org. Without network access it errors, and testthat aborts before running any test.The lookup is now wrapped in
tryCatch(). Offline,is_releasebecomesFALSE, which only makes the cloud tests skip, as they already do without plotly credentials. Three other tests that download from GitHub and cdn.plot.ly still fail offline; they're left as they are. plotly has no CI that runs its tests today, so running the rest in Nix, even with those three failing, still adds a lot of coverage: 1,445 tests now pass.Part of DPI-5056, which moves the R package tests from CircleCI to Nix, where they run without network access.
Please do not merge this PR when approving, it will be merged in bulk with other PRs for DPI-5056.