Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: assertj/assertj
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: DirkToewe/assertj
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Dec 18, 2022

  1. Comparables::assertIsBetween String alloc. removed 

    Comparables::checkBoundsValidity, which is used by Comparables::assertIsBetween, does build an error message String even if the assertion does not fail. This results in noticeable overhead. The JVM can hardly eliminate the String building since `start.toString()`, `operator.toString()` and `end.toString()` may have side effects. This commit moves the String building inside a `Supplier<String>` which is only evaluated on failure.
    @DirkToewe
    DirkToewe committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    dee396b View commit details
    Browse the repository at this point in the history
Loading