Skip to content

Enable release please node workspace plugin - #1688

Open
hazdl wants to merge 1 commit into
mainfrom
hz/release-please-node-workspace
Open

Enable release please node workspace plugin#1688
hazdl wants to merge 1 commit into
mainfrom
hz/release-please-node-workspace

Conversation

@hazdl

@hazdl hazdl commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

 Enable Release Please's node-workspace plugin to make release generation aware of workspace package dependencies.
 
Problem
Dashboard depends on both workflows-lib and relay-workflows-lib, but Release Please currently treats these packages independently.
 
This means changes in the shared libraries can affect Dashboard functionality without triggering a new Dashboard release. As a result, no new Dashboard image is published and there is nothing new for ArgoCD to deploy.
 
Solution
 
Enabled the node-workspace plugin so Release Please can understand the dependency relationships between workspace packages.
 
Expected behaviour:
 

  • Changes in workflows-lib or relay-workflows-lib can trigger a Dashboard version bump when appropriate.
  • A new Dashboard release can be generated automatically.
  • A new Dashboard image can be published and deployed through ArgoCD.

@JamesDoingStuff

JamesDoingStuff commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

For this to work, I think we might also need to explicitly give a version for workflows-lib and relay-workflows-lib in dashboard's package.json, rather than what we have now:

  "dependencies": {
    "keycloak-js": "^26.2.4",
    "msw": "^2.15.0",
    "react-router-dom": "^7.18.4",
    "relay-workflows-lib": "*",
    "workflows-lib": "*"
  },

@hazdl

hazdl commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sounds right.
Looking at the current setup, both Dashboard and relay-workflows-lib reference their workspace dependencies using *. I suspect the node-workspace plugin may need explicit versioned workspace dependencies in order to propagate version bumps correctly. I'll dig into the plugin documentation to confirm whether we should be using workspace:*, workspace:^, or explicit versions before we merge this change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davehadley davehadley Awaiting requested review from davehadley
@JamesDoingStuff JamesDoingStuff Awaiting requested review from JamesDoingStuff

At least 1 approving review is required to merge this pull request.

Assignees

See More

@hazdl hazdl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hazdl @JamesDoingStuff