[react-infinite-scroller] Fix tests when ReactFragment does not include {}#59671
Conversation
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59671,
"author": "eps1lon",
"headCommitOid": "fb795a6ee8509d9cc3b863c4be3ff4ad67e554e6",
"mergeBaseOid": "7de5a3274b57a5602670134ef0a36fd4f17fa179",
"lastPushDate": "2022-04-03T14:45:18.000Z",
"lastActivityDate": "2022-04-05T07:01:45.000Z",
"mergeOfferDate": "2022-04-05T05:25:05.000Z",
"mergeRequestDate": "2022-04-05T07:01:45.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "react-infinite-scroller",
"kind": "edit",
"files": [
{
"path": "types/react-infinite-scroller/react-infinite-scroller-tests.tsx",
"kind": "test"
}
],
"owners": [
"Lapanti",
"psrebniak",
"WrathZA",
"daggerjames"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "psrebniak",
"date": "2022-04-05T05:24:25.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1086885840,
"ciResult": "pass"
} |
typescript-bot
added
the
Popular package
|
🔔 @lapanti @psrebniak @WrathZA @daggerjames — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Owner Approved
|
@eps1lon: Everything looks good here. I am ready to merge this PR (at fb795a6) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@lapanti, @psrebniak, @WrathZA, @daggerjames: you can do this too.) |
|
Ready to merge |
3 participants
Given the name of the
elementprop, the prop probably does not support a component but an element. @cvetanov Could you take a look and tell me if we should extendelementto acceptComponentTypeor really only passReactNodein which case the proposed diff should fix any future issues.We plan to remove
{}fromReactFragmentsince it's not actually an allowed type for children of host components (e.g.<div>{{}}</div>would throw at runtime) (see #56026 for previous attempts).This change is required to pass #56210