[react-form] Correctly extend FieldProps in RadioGroup#58293
Merged
sandersn merged 1 commit intoJan 20, 2022
Conversation
eps1lon
commented
Jan 18, 2022
| export class RadioGroup | ||
| extends React.Component< | ||
| FieldProps & { children?: ((props: FieldApi) => RenderReturn) | RenderReturn | undefined } | ||
| Omit<FieldProps, 'children'> & { children?: ((props: FieldApi) => RenderReturn) | RenderReturn | undefined } |
Collaborator
Author
There was a problem hiding this comment.
Previous intersection only worked because we intersected {} & (props) => RenderReturn.
Contributor
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58293,
"author": "eps1lon",
"headCommitOid": "547cdeafe9331adec1a027fcea5fcadbc4c3b5b0",
"mergeBaseOid": "c609479376c92be2991c6d072a70201f7e225047",
"lastPushDate": "2022-01-18T19:29:27.000Z",
"lastActivityDate": "2022-01-18T22:04:00.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-form",
"kind": "edit",
"files": [
{
"path": "types/react-form/v2/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cameron-mcateer",
"TiuSh",
"Toliak"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Toliak",
"date": "2022-01-18T22:04:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1015777409,
"ciResult": "pass"
} |
Contributor
|
🔔 @cameron-mcateer @TiuSh @Toliak — please review this PR in the next few days. Be sure to explicitly select |
Toliak
approved these changes
Jan 18, 2022
typescript-bot
added
the
Owner Approved
martin-badin
pushed a commit
to martin-badin/DefinitelyTyped
that referenced
this pull request
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We plan to remove
{}fromReactFragmentsince it's not actually an allowed type for children of host components (e.g.<div>{{}}</div>would throw at runtime) (see #56026 for previous attempts).This change is required to pass #56210