@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• react-tracking — on npm, on unpkg
  • owner-approval: @chenasraf

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 56264,
  "author": "eps1lon",
  "headCommitOid": "6e20b650a787f0fbadfb27ac59eab577556e15f6",
  "lastPushDate": "2021-10-07T11:04:52.000Z",
  "lastActivityDate": "2021-10-14T08:56:51.000Z",
  "mergeOfferDate": "2021-10-13T23:50:43.000Z",
  "mergeRequestDate": "2021-10-14T08:56:51.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-tracking",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-tracking/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "damassi",
        "chenasraf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2021-10-13T23:50:09.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "chenasraf",
      "date": "2021-10-07T16:30:52.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 937588742,
  "ciResult": "pass"
}

Hey @eps1lon,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @alloy @damassi @chenasraf — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@eps1lon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@eps1lon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@chenasraf Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

/cc @alloy

⏳ Hi @eps1lon,

It's been a few days since this PR was approved by chenasraf and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@eps1lon: Everything looks good here. I am ready to merge this PR (at 6e20b65) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alloy, @damassi, @chenasraf: you can do this too.)

Ready to merge