[moxy/next-router-scroll] withRouterScroll receives a ComponentType#56033
Merged
sandersn merged 2 commits intoSep 30, 2021
Merged
Conversation
Contributor
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56033,
"author": "eps1lon",
"headCommitOid": "dea435e4962257f10656529b54b2ce1cf3517f8b",
"lastPushDate": "2021-09-30T07:40:36.000Z",
"lastActivityDate": "2021-09-30T08:30:45.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "moxy__next-router-scroll",
"kind": "edit",
"files": [
{
"path": "types/moxy__next-router-scroll/index.d.ts",
"kind": "definition"
},
{
"path": "types/moxy__next-router-scroll/with-router-scroll.d.ts",
"kind": "definition"
}
],
"owners": [
"me"
],
"addedOwners": [
"heozeop"
],
"deletedOwners": [
"me"
],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "heozeop",
"date": "2021-09-30T08:30:45.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 929530683,
"ciResult": "pass"
} |
Contributor
|
🔔 @me — please review this PR in the next few days. Be sure to explicitly select |
1 similar comment
Contributor
|
🔔 @me — please review this PR in the next few days. Be sure to explicitly select |
Contributor
heozeop
approved these changes
Sep 30, 2021
typescript-bot
added
the
Other Approved
Contributor
|
Sorry for late review. @eps1lon |
heozeop
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revealed by #56026
Change is already tested but only works due to
ReactNodeincluding{}:DefinitelyTyped/types/moxy__next-router-scroll/moxy__next-router-scroll-tests.tsx
Lines 47 to 53 in 43f20db
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
[ ]If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.