[react-portal] Remove usage of deprecated React.Props#56031
Merged
typescript-bot merged 1 commit intoSep 29, 2021
Merged
Conversation
eps1lon
commented
Sep 28, 2021
eps1lon
commented
Sep 28, 2021
Contributor
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56031,
"author": "eps1lon",
"headCommitOid": "133c4e85cd268766eeb79ee05f2555435951c61b",
"lastPushDate": "2021-09-28T18:31:29.000Z",
"lastActivityDate": "2021-09-29T06:52:06.000Z",
"mergeOfferDate": "2021-09-28T20:16:36.000Z",
"mergeRequestDate": "2021-09-29T06:52:06.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "react-portal",
"kind": "edit",
"files": [
{
"path": "types/react-portal/index.d.ts",
"kind": "definition"
}
],
"owners": [
"shuntksh",
"HorusGoul"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-09-28T20:15:58.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "HorusGoul",
"date": "2021-09-28T19:16:57.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 929523120,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
Contributor
|
🔔 @shuntksh @HorusGoul — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
Collaborator
Author
|
Ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revealed by #56026
Change is already tested but only works due to
ReactNodeincluding{}Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
[ ]Provide a URL to documentation or source code which provides context for the suggested changes: <>[ ]If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.