Remove breaking change (react)#26945
Conversation
Someone added a single line breaking change to React's Typedefs causing a worldwide problem for people using `@types/react`. If this change ever goes in it needs to be at a SemVer version change, not as a patch change...
|
@Rycochet Thank you for submitting this PR! 🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@Rycochet The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Hotell
left a comment
There was a problem hiding this comment.
You need to update tests
Also your comments like "someone added" , "causing a worldwide problem" are not very polite but sure go for it, it's open source you can sh*t on people right ? :)
|
Closed in favour of #26946 |
Someone added a single line breaking change to React's Typedefs causing a worldwide problem for people using
@types/react. If this change ever goes in it needs to be at a SemVer version change, not as a patch change...Note that without this reversion all the React examples (including the one linked below) would actually be wrong as they would need to check for the existence of
this.statebefore using it.The version number shouldn't be changed as this should be a correction for the previous PR...
Referencing #26813
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.