Skip to content

Remove breaking change (react)#26945

Closed
Rycochet wants to merge 1 commit into
DefinitelyTyped:masterfrom
Rycochet:patch-1
Closed

Remove breaking change (react)#26945
Rycochet wants to merge 1 commit into
DefinitelyTyped:masterfrom
Rycochet:patch-1

Conversation

@Rycochet
Copy link
Copy Markdown
Contributor

Someone added a single line breaking change to React's Typedefs causing a worldwide problem for people using @types/react. If this change ever goes in it needs to be at a SemVer version change, not as a patch change...

Note that without this reversion all the React examples (including the one linked below) would actually be wrong as they would need to check for the existence of this.state before using it.

The version number shouldn't be changed as this should be a correction for the previous PR...

Referencing #26813

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://reactjs.org/docs/state-and-lifecycle.html
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

Someone added a single line breaking change to React's Typedefs causing a worldwide problem for people using `@types/react`. If this change ever goes in it needs to be at a SemVer version change, not as a patch change...
@Rycochet Rycochet requested a review from johnnyreilly as a code owner June 29, 2018 10:31
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Jun 29, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

@Rycochet Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

@Rycochet The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Copy link
Copy Markdown
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update tests

Also your comments like "someone added" , "causing a worldwide problem" are not very polite but sure go for it, it's open source you can sh*t on people right ? :)

@Rycochet
Copy link
Copy Markdown
Contributor Author

Closed in favour of #26946

@Rycochet Rycochet closed this Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants