-
Notifications
You must be signed in to change notification settings - Fork 562
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: wbluke/readable-code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Dayoming/readable-code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 17 commits
- 41 files changed
- 1 contributor
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd345f3 - Browse repository at this point
Copy the full SHA cd345f3View commit details
Commits on Oct 7, 2024
-
메서드 추출, 이름 짓기, 매직 넘버/매직 스트링 추출, 부정어 삭제, 의도적 예외 AppException 추가
Configuration menu - View commit details
-
Copy full SHA for 6f616e3 - Browse repository at this point
Copy the full SHA 6f616e3View commit details -
Cell과 관심사 분리 열렸다/닫혔다는 개념과 사용자가 체크했다는 개념에 대한 도메인 지식 적용
Configuration menu - View commit details
-
Copy full SHA for 4f69596 - Browse repository at this point
Copy the full SHA 4f69596View commit details -
- 프로그램을 실행하는 진입점 역할/지뢰찾기 도메인을 가지고 지뢰찾기 게임을 실행하는 부분을 나눔 - 입출력은 별개의 책임으로 클래스를 나누어 지뢰찾기 도메인 클래스와 협력 - GameBoard를 분리해 객체에 메시지를 보내 행동 요청
Configuration menu - View commit details
-
Copy full SHA for 5a84baf - Browse repository at this point
Copy the full SHA 5a84bafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55d4c13 - Browse repository at this point
Copy the full SHA 55d4c13View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f39eaf4 - Browse repository at this point
Copy the full SHA f39eaf4View commit details -
- Cell 클래스를 상속받는 EmptyCell, LandMineCell, NumberCell 생성 - 부모의 책임을 준수하고 각 클래스가 기능을 확장할 수 있도록 설계
Configuration menu - View commit details
-
Copy full SHA for be5a15c - Browse repository at this point
Copy the full SHA be5a15cView commit details -
- 각각 초기화, 실행의 책임을 가지고 있는 GameRunnable과 GameInitializable 인터페이스를 분리 - 하위 구현체에서 필요한 기능만 구현하도록 설계
Configuration menu - View commit details
-
Copy full SHA for d60a021 - Browse repository at this point
Copy the full SHA d60a021View commit details -
- ConsoleInputHandler, ConsoleOutputHandler를 InputHandler, OutputHandler라는 추상 객체에 의존하도록 수정
Configuration menu - View commit details
-
Copy full SHA for 83150d8 - Browse repository at this point
Copy the full SHA 83150d8View commit details -
- 기존의 Cell을 상속받던 구조를 조합으로 변경 - Cell에서 사용하던 isFlagged, isOpened 필드를 CellState로 분리해 상태만 따로 관리할 수 있도록 책임 분리 - Cell을 인터페이스로 구현하고 각 기존의 자식들은 구현체로 변경해 유연한 변경이 가능하도록 수정
Configuration menu - View commit details
-
Copy full SHA for 37a9f7b - Browse repository at this point
Copy the full SHA 37a9f7bView commit details -
- CellPosition, RelativePosition을 Value Object로 분리해서 의미를 더 명확하게 수정
Configuration menu - View commit details
-
Copy full SHA for b8bc98f - Browse repository at this point
Copy the full SHA b8bc98fView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c9f37c8 - Browse repository at this point
Copy the full SHA c9f37c8View commit details -
- InputHandler와 OutputHandler를 인터페이스로 변경 - 구현체인 ConsoleInputHandler, ConsoleOutputHandler 구현 - 입출력을 담당하던 각 객체를 추상화하고 인터페이스를 의존하도록 함으로써 이후에 입출력 방식이 변경되어도 유연하게 대처 가능
Configuration menu - View commit details
-
Copy full SHA for 3c5fdd3 - Browse repository at this point
Copy the full SHA 3c5fdd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8164b41 - Browse repository at this point
Copy the full SHA 8164b41View commit details -
- PassSelector 클래스를 추가해 Pass 선택 로직을 분리 - StudyCafePassMachine은 이제 직접 Pass를 선택하는 로직을 수행하는 대신 PassSelector에게 selectPass라는 메시지를 전달해 Pass를 선택하는 책임을 줌
Configuration menu - View commit details
-
Copy full SHA for 5689b56 - Browse repository at this point
Copy the full SHA 5689b56View commit details -
- StudyCafePassMachine 내부에서 다루던 List<StudyCafePass> 들을 일급 컬렉션으로 관리
Configuration menu - View commit details
-
Copy full SHA for 20d7f75 - Browse repository at this point
Copy the full SHA 20d7f75View commit details -
Configuration menu - View commit details
-
Copy full SHA for b80a490 - Browse repository at this point
Copy the full SHA b80a490View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main