Skip to content

Fix brick usage via interface - #456

Merged
DavidVujic merged 6 commits into
mainfrom
fix-brick-usage-via-interface
Jul 4, 2026
Merged

DavidVujic merged 6 commits into
mainfrom
fix-brick-usage-via-interface

Conversation

@DavidVujic

@DavidVujic DavidVujic commented Jul 3, 2026 •

Copy link
Copy Markdown
Owner

Description

Removing brick interface bypassing, and circular references that was reported by the poly deps --interface command:

 ℹ Found in check: grouping is not part of the public interface of imports.                                                                 
 ℹ Found in interface: usages is not part of the public interface of imports.                                                               
 ℹ Found in commands: core is not part of the public interface of deps.                                                                     
 ℹ Found in pdm_workspace_hooks: hooks is not part of the public interface of pdm.                                                          
 ℹ Found in pdm_project_hooks: hooks is not part of the public interface of pdm.                                                            
 ℹ Found in poetry: component is not part of the public interface of bricks.                                                                
 ℹ Found in poetry: base is not part of the public interface of bricks.                                                                     
 ℹ Found in commands: values is not part of the public interface of bricks.                                                                 
 ℹ Found in cli: component is not part of the public interface of bricks.                                                                   
 ℹ Found in cli: base is not part of the public interface of bricks.                                                                        
 ℹ Found in info: component is not part of the public interface of bricks.                                                                  
 ℹ Found in info: base is not part of the public interface of bricks.                                                                       

 ℹ bricks is used by info and also uses info.                                                                                               
 ℹ info is used by bricks and also uses bricks.         

Motivation and Context

This repo should align with what is recommended for bricks in the Polylith architecture, communicating via explicit interfaces.

Also: circular brick dependencies can cause future issues and should be fixed.

How Has This Been Tested?

✅ CI
✅ run the poly commands

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Before:

poly-deps

After:

poly-deps-after

@DavidVujic
DavidVujic marked this pull request as ready for review July 3, 2026 14:07
@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

@DavidVujic
DavidVujic merged commit 1441411 into main Jul 4, 2026
4 checks passed
@DavidVujic
DavidVujic deleted the fix-brick-usage-via-interface branch July 4, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant