Skip to content

feat(poly diff): multiple diff tag patterns - #131

Merged
DavidVujic merged 2 commits into
mainfrom
diff-tag-patterns
Nov 5, 2023
Merged

DavidVujic merged 2 commits into
mainfrom
diff-tag-patterns

Conversation

@DavidVujic

@DavidVujic DavidVujic commented Nov 4, 2023 •

Copy link
Copy Markdown
Owner

Description

Add possibility to have more than one git tag pattern, such as stable and release.

fixes #130

TOML docs about Table structure: https://toml.io/en/v1.0.0#table
Clojure example: https://github.com/polyfy/polylith/blob/master/workspace.edn
Clojure docs: https://polylith.gitbook.io/poly/workflow/tagging

Motivation and Context

This will make it possible to calculate differences in a more fine-grained way.

Example:
the diff between a feature branch and the latest stable version (usually the main branch),
or the diff based on a release version.

usage:

# using the default "stable" in the new workspace.toml table, or the already existing "git_tag_pattern"
poetry poly diff
# calculate diff based on the latest release tag. The pattern is defined in workspace.toml
poetry poly diff --since release

How Has This Been Tested?

Local install, tested on this repo + the python polylith example repo.
CI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidVujic
DavidVujic marked this pull request as ready for review November 5, 2023 15:04
@DavidVujic DavidVujic changed the title WIP: multiple diff tag patterns feat(poly diff): multiple diff tag patterns Nov 5, 2023
@DavidVujic
DavidVujic merged commit 3abdda6 into main Nov 5, 2023
@DavidVujic
DavidVujic deleted the diff-tag-patterns branch November 5, 2023 15:08
@licht1stein

Copy link
Copy Markdown

Wow that was quick. Thank you!

@DavidVujic

Copy link
Copy Markdown
Owner Author

😄 There is a new version out: v1.12.0

Docs update: https://davidvujic.github.io/python-polylith-docs/configuration/

In the workspace.toml:

[tool.polylith.tag.patterns]
stable = "stable-*"
release = "v[0-9]*"

I hope this will help, and thank you for sharing your ideas about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for different git tag patterns (stable-*, release-* etc.)

2 participants