Skip to content

feat(poly check and libs): add --alias option - #112

Merged
DavidVujic merged 5 commits into
mainfrom
dependency-aliases
Sep 24, 2023
Merged

DavidVujic merged 5 commits into
mainfrom
dependency-aliases

Conversation

@DavidVujic

@DavidVujic DavidVujic commented Sep 24, 2023 •

Copy link
Copy Markdown
Owner

Description

Useful when an import differ from the library name, such as:
library name "opencv-python" and the actual import is "cv2". This will cause the poly check and poly libs to report missing dependencies.

The --alias option will help the commands with understanding the imports.

Example usage:

poetry poly check --alias opencv-python=cv2

With several aliases:

poetry poly check --alias opencv-python=cv2 --alias matplotlib=mpl_toolkit

Motivation and Context

Partially solves #107

How Has This Been Tested?

Local install and testing with the python-polylith-example repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic
DavidVujic marked this pull request as ready for review September 24, 2023 18:46
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidVujic
DavidVujic merged commit fa124ae into main Sep 24, 2023
@DavidVujic
DavidVujic deleted the dependency-aliases branch September 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant