Conversation
Library names: libcJSON -> libcjson libcJSON_utils -> libcjson_utils
We configure and install a pkg-config file so that our compilation and linking flags can be more easily found using pkg-config.
This is also what other projects are doing.
Turned off by default.
These files will allow cmake based projects to find the library using find_package(cJSON). If successful, they can use CJSON_LIBRARIES and CJSON_INCLUDE_DIRS. Other build systems can use a similar approach to pkg-config: cmake --find-package -DNAME=cJSON -DCOMPILER_ID=GNU -DLANGUAGE=C -DCMAKE_PREFIX_PATH=<path-to-non-sytem-installation-path> -DMODE=LINK or with MODE COMPILE or EXISTS.
Fix library and include paths in pkg-config, CMakeLists.txt and the CMake config files.
The prior approach was exporting paths from the build environment.
This is for compatibility reasons with old CMake 2.8 versions.
This can be disabled when the exporting of the targets causes problems.
And remove special handling of SunOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.0.0 is finally finished.
Now is the time for review before I merge the changes into master and tag the release.