Implement Advanced DSL#385
Draft
Entenwilli wants to merge 10 commits intomainfrom
Draft
Conversation
Entenwilli
requested review from
01Parzival10,
BenjaminArp,
Kr0nox,
Lostlias,
Nicolas-Boltz,
manuelcorcoles and
uuqjz
Entenwilli
added
enhancement
BenjaminArp
reviewed
Apr 7, 2026
| } | ||
|
|
||
| public static ParseResult<DestinationSelectors> fromString(StringView string, DSLContext context) { | ||
| string.skipWhitespace(); |
Contributor
There was a problem hiding this comment.
the string.skipWhitespace() gets called 5 times in a row without the string changing is this corect/intended?
| public final class SourceSelectors extends AbstractParseable { | ||
| private final Optional<DataSourceSelectors> dataSourceSelectors; | ||
| private final Optional<VertexSourceSelectors> vertexSourceSelectors; | ||
| private final DataSourceSelectors dataSourceSelectors; |
Contributor
There was a problem hiding this comment.
this now requires the dsl to specify both data and vertex Selectors? so smth like data neverflows vertex internal !logging is no longer allowed?
| private static final String DSL_OPERATOR = "&&"; | ||
|
|
||
| private final AbstractSelector lhs; | ||
| private final AbstractSelector rhs; |
Contributor
There was a problem hiding this comment.
Don´t use acronyms, lefthandside and righthandside?
| if (string.startsWith(DSL_OPERATOR)) { | ||
| return string.expect(DSL_OPERATOR); | ||
| } | ||
| string.skipWhitespace(); |
Contributor
There was a problem hiding this comment.
same skipWhitespace as above, i belive the first call in fromString is skip whitespace
| if (string.empty() || string.invalid()) { | ||
| return ParseResult.error("Not a valid constraint"); | ||
| } | ||
| string.skipWhitespace(); |
Contributor
There was a problem hiding this comment.
repetive skipWhitespace, i will not comment every occurence of this
| return this.inverted ? DSL_INVERTED_SYMBOL + DSL_KEYWORD + " " + this.name : DSL_KEYWORD + " " + this.name; | ||
| StringBuilder stringBuilder = new StringBuilder(); | ||
| if (this.inverted) | ||
| stringBuilder.append(DSL_INVERTED_SYMBOL + " "); |
Contributor
There was a problem hiding this comment.
Add brackets to if (maybe we want to add this to the formatter)
| } | ||
|
|
||
| public AdvancedAnalysisConstraint(String name, | ||
| org.dataflowanalysis.analysis.dsl.groups.SourceSelectors sourceSelectors, FlowType flowType, |
Contributor
There was a problem hiding this comment.
why don´t use the "simple" type instead of the complete declaration?
| this.dataSourceSelectors = new DataSourceSelectors(); | ||
| this.vertexDestinationSelectors = new VertexDestinationSelectors(); | ||
| this.conditionalSelectors = new ConditionalSelectors(); | ||
| this.sourceSelectors = new org.dataflowanalysis.analysis.dsl.groups.SourceSelectors(); |
Contributor
There was a problem hiding this comment.
Why do you use the complete type?
|
|
||
| public SimpleAnalysisConstraint(String name, | ||
| org.dataflowanalysis.analysis.dsl.groups.SourceSelectors sourceSelectors, | ||
| DestinationSelectors destinationSelectors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the advanced DSL with the syntax we discussed:
neverFlows,flows,alwaysFlowsandnotAlwaysFlowsany,vertexNameanddataNamecontainsfor namesThe new prefix for instances of the DSL is
*Examples