Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
CI Test ResultsRun: #35889822996 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-09-23 16:56:08 UTC |
Contributor
| @RetryTest(10) | ||
| @TestTemplate | ||
| @ValueSource(strings = {"vm", "vmx"}) | ||
| public void testStubUnwinding(@CStack String cstack) throws Exception { |
Contributor
|
🔗 Commit SHA: 8ea6e2b | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds precomputed unwind info for AArch64 runtime stubs. The profiler decodes each stub once, at creation time (JVMTI
DynamicCodeGenerated), and stores a small phase table.cstack=vmunwinding reads this table first. The old name-based rules stay as fallback.Motivation:
VM unwinding matches stub names against a list. Names change between JDK versions and vendor builds. An unlisted stub fails to unwind and produces a
break_unwind_stub_failedframe. Also, a sample that lands mid-prologue or mid-epilogue gets the wrong rule, because the old code knows only the steady state.Additional Notes:
#ifdef __aarch64__.walkvm_stub_info_{classified,unclassified,hit,fallback,registration_failed}.How to test the change?:
stubUnwindInfo_ut.cpp(42 cases, assembler-verified encodings).StubUnwindCpuTest. On aarch64 it asserts no break frames and a Java frame above each stub frame.For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.