Relax benchmark commandline restriction - #243
Merged
Merged
Conversation
Contributor
Contributor
|
🔧 Report generated by pr-comment-scanbuild |
jbachorik
reviewed
Jul 9, 2025
jbachorik
left a comment
jbachorik
left a comment
Collaborator
There was a problem hiding this comment.
I wonder, could you go the extra mile and completely switch to the JMH standard arguments?
Eg. using the JMH command line argument for 'include' instead of hardcoding it in the launcher?
zhengyu123
force-pushed
the
zgu/jmh-arguments
branch
from
July 10, 2025 13:05
7281eaf to
f97ff03
Compare
Contributor
Author
Not sure this is what you want. This matches my normal usage pattern, e.g.
|
jbachorik
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Allow additional jmh arguments, e.g. profiling option
Motivation:
Run jmh benchmark with profiler, e.g.
java -jar ddprof-stresstest.jar throughput.ThreadFilterBenchmark -prof perfasmAdditional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!