Skip to content

JVM Flags access API #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 15 commits into from
Nov 12, 2024
Merged

JVM Flags access API #149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a59fc26
Introduce an API to access JVM flags directly
jbachorik Nov 5, 2024
5559c50
Try increasing retry limit for ObjectSampleDumpSmokeTest
jbachorik Nov 5, 2024
c71a738
Add more javadocs
jbachorik Nov 5, 2024
82fa8a1
Fix assumption
jbachorik Nov 5, 2024
619c5b7
Fix condition
jbachorik Nov 5, 2024
340884a
Zing does not support vmstructs, too
jbachorik Nov 5, 2024
6dd9ae7
Deal with the JVM flag implementation differences
jbachorik Nov 6, 2024
1ceb055
Decouple library initialization from profiler initialization
jbachorik Nov 6, 2024
bb4e9ea
success -> succeeded
jbachorik Nov 8, 2024
a5e686e
Update ddprof-test/src/test/java/com/datadoghq/profiler/JVMAccessTest…
jbachorik Nov 8, 2024
4c214f3
Update ddprof-test/src/test/java/com/datadoghq/profiler/JavaProfilerT…
jbachorik Nov 8, 2024
078b5f7
Use shared Libraries instance
jbachorik Nov 11, 2024
ae50b2a
Simplify JVMFlags API
jbachorik Nov 11, 2024
24a142f
Fix flag C++ calls
jbachorik Nov 11, 2024
4102eb3
More fixes
jbachorik Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deal with the JVM flag implementation differences
  • Loading branch information
@jbachorik
jbachorik committed Nov 8, 2024
commit 6dd9ae7d47b370d00c33e053484ea1a484473ec0
34 changes: 34 additions & 0 deletions ddprof-lib/src/main/cpp/vmStructs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,40 @@ void *JVMFlag::find(const char *name) {
return NULL;
}

int JVMFlag::type() {
if (VM::hotspot_version() < 16) { // in JDK 16 the JVM flag implementation has changed
char* type_name = *(char **)at(_flag_type_offset);
if (type_name == NULL) {
return JVMFlag::Type::Unknown;
}
if (strcmp(type_name, "bool") == 0) {
return JVMFlag::Type::Bool;
} else if (strcmp(type_name, "int") == 0) {
return JVMFlag::Type::Int;
} else if (strcmp(type_name, "uint") == 0) {
return JVMFlag::Type::Uint;
} else if (strcmp(type_name, "intx") == 0) {
return JVMFlag::Type::Intx;
} else if (strcmp(type_name, "uintx") == 0) {
return JVMFlag::Type::Uintx;
} else if (strcmp(type_name, "uint64_t") == 0) {
return JVMFlag::Type::Uint64_t;
} else if (strcmp(type_name, "size_t") == 0) {
return JVMFlag::Type::Size_t;
} else if (strcmp(type_name, "double") == 0) {
return JVMFlag::Type::Double;
} else if (strcmp(type_name, "ccstr") == 0) {
return JVMFlag::Type::String;
} else if (strcmp(type_name, "ccstrlist") == 0) {
return JVMFlag::Type::Stringlist;
} else {
return JVMFlag::Type::Unknown;
}
} else {
return *(int *)at(_flag_type_offset);
}
}

void *JVMFlag::find(const char *name, int type_mask) {
if (_flags_addr != NULL && _flag_size > 0) {
for (int i = 0; i < _flag_count; i++) {
Expand Down
16 changes: 15 additions & 1 deletion ddprof-lib/src/main/cpp/vmStructs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,11 +528,25 @@ class CodeHeap : VMStructs {

class JVMFlag : VMStructs {
public:
enum Type {
Bool = 0,
Int = 1,
Uint = 2,
Intx = 3,
Uintx = 4,
Uint64_t = 5,
Size_t = 6,
Double = 7,
String = 8,
Stringlist = 9,
Unknown = -1
};

static void *find(const char *name);
static void *find(const char *name, int type_mask);

const char *name() { return *(const char **)at(_flag_name_offset); }
int type() { return *(int *)at(_flag_type_offset); }
int type();

void *addr() { return *(void **)at(_flag_addr_offset); }
};
Expand Down